zhougit86 commented on code in PR #22624:
URL: https://github.com/apache/flink/pull/22624#discussion_r1227751941
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##########
@@ -556,7 +556,7 @@ object CodeGenUtils {
s"$rowTerm.setNullAt($indexTerm)"
}
- if (fieldType.isNullable) {
+ if (fieldType.isNullable ||
fieldExpr.nullTerm.startsWith("castRuleResultIsNull")) {
Review Comment:
Thanks for advice, I updated it and make the target type nullable , which
makes it the same as the legacy codegen return value. Please let me know your
thinking
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##########
@@ -556,7 +556,7 @@ object CodeGenUtils {
s"$rowTerm.setNullAt($indexTerm)"
}
- if (fieldType.isNullable) {
+ if (fieldType.isNullable ||
fieldExpr.nullTerm.startsWith("castRuleResultIsNull")) {
Review Comment:
Thanks for advice, I updated it and make the target type nullable , which
makes it the same as the legacy codegen return value. Please let me know your
thinking @snuyanzin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
