StefanRRichter commented on code in PR #22771:
URL: https://github.com/apache/flink/pull/22771#discussion_r1228254143
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java:
##########
@@ -125,10 +130,16 @@ public WriteOptions getOptions() {
@Override
public void close() throws RocksDBException {
- if (batch.count() != 0) {
- flush();
+ try {
+ if (batch.count() != 0) {
+ flush();
+ }
+ } finally {
+ IOUtils.closeQuietly(batch);
+ if (ownsWriteOptions) {
+ IOUtils.closeQuietly(options);
+ }
Review Comment:
Sorry if it's a stupid question, but what is "closer"? Like closable
registry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
