XComp commented on PR #22737: URL: https://github.com/apache/flink/pull/22737#issuecomment-1590664616
> You can look at the commits in https://github.com/zentol/flink-ci-docker/commits/master. > The last 4 commits are relevant for this upgrade. Thanks for the reference: That helps in understanding this change :+1: > I don't think the reviewability is impacted by this being in my own repo thinking You're right - the remark on using your repository isn't related to improving the reviewability. That one was more of a organizational/political remark. > You can also check the layers in https://hub.docker.com/layers/chesnay/flink-ci/java_8_11_17_maven_386_v2/images/sha256-566fc00ee070850d47dc082e50bcdfbc7a07cea5b7bd3bc08c3943eba1cc9e4b?context=repo. That's actually a good hint - I wasn't aware of that. Thanks > It doesn't belong in flink-docker imo; should be a separate repo. (Ideally flink-docker is mostly merged into the flink repo eventually, only serving as a publishing area for official-images.) I just noticed that your repo is just a fork of [flink-ci/flink-ci-docker](https://github.com/flink-ci/flink-ci-docker) which sounds more appropriate but isn't because it's under Ververica, instead :man_shrugging: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
