zentol opened a new pull request, #22778:
URL: https://github.com/apache/flink/pull/22778

   POJOs should be public so they are serialized with the pojo serializer.
   
   The modification to the `MinMaxSelector` is necessary because by being 
treated as a pojo the partitioning is being changed. Seemingly the `first` 
field of the `ComparablePojo` dominates the partitioning (ranging from 0-2), 
causing only 3 partitions to be created but the job runs with p=4.
   
   I don't really know what the semantics for range partitioning of Kryo 
records are, and am somewhat confused that this test passed with Kryo in the 
first place because it does check for order of elements within partitions. 
:thinking: 
   
   Anyhow, since this is a `DataSet` test I'm not too inclined to dig any 
deeper into the why's. The `hasNext` check is useful anyway because the test 
should pass with any parallelism, even one greater than the number of elements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to