zentol commented on code in PR #22601:
URL: https://github.com/apache/flink/pull/22601#discussion_r1229632471
##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java:
##########
@@ -247,7 +247,7 @@ private LeaderElection createLeaderElection(String
leaderName) throws Exception
leaderElectionService.startLeaderElectionBackend();
closeableRegistry.registerCloseable(leaderElectionService);
- return leaderElectionService.createLeaderElection();
+ return leaderElectionService.createLeaderElection(leaderName);
Review Comment:
Is that still missing from the PR?
Because it looks like we're always passing a constant value into
`AbstractHaServices#createLeaderElection`, that forwards that same static value
into the LeaderElection and DriverFactory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
