XComp commented on PR #22640: URL: https://github.com/apache/flink/pull/22640#issuecomment-1591349303
> I don't really follow the UUID change. If the multiCLES got by without it so far, what do we need it for now? > > the HA backend should be the owner of the session ID: Theoretically, it could provide such a session ID. > > Sure, is either ZK/k8s doing that though? Would we gain anything by it? The initial motivation was to align it with `LeaderElectionEventHandler#onGrantLeadership` to reduce the effort in migrating the legacy tests to the new interface (it feels like there are more tests for the legacy code; but I didn't count). I found it handy in tests where the test code can define the sessionID as the expected one and we can rely on it without needing to extract it from somewhere. Also from a semantical point of view it made sense (as it is stated in the comment you quoted). But I can try to make hide the sessionID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
