becketqin commented on code in PR #22509:
URL: https://github.com/apache/flink/pull/22509#discussion_r1230258326
##########
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java:
##########
@@ -231,6 +231,27 @@ public class YarnConfigOptions {
.withDescription(
"A comma-separated list of tags to apply to the
Flink YARN application.");
+ /**
+ * Users and groups to give VIEW access.
+ *
https://www.cloudera.com/documentation/enterprise/latest/topics/cm_mc_yarn_acl.html
+ */
+ public static final ConfigOption<String> APPLICATION_VIEW_ACLS =
+ key("yarn.view.acls")
+ .stringType()
+ .defaultValue("")
+ .withDescription(
+ "Users and groups to give VIEW access. The ACLs
are of for"
+ + "
comma-separated-usersspacecomma-separated-groups");
Review Comment:
We should modify the description here to:
```
Users and groups to give VIEW access. The ACLs are of for
comma-separated-users<space>comma-separated-groups. Wildcard ACL is also
supported. The only valid wildcard ACL is *, which grants permission to all the
groups and users.
```
The HTML files are generated from the description here.
Also, probably should mention the wildcard as well.
##########
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java:
##########
@@ -231,6 +231,27 @@ public class YarnConfigOptions {
.withDescription(
"A comma-separated list of tags to apply to the
Flink YARN application.");
+ /**
+ * Users and groups to give VIEW access.
+ *
https://www.cloudera.com/documentation/enterprise/latest/topics/cm_mc_yarn_acl.html
+ */
+ public static final ConfigOption<String> APPLICATION_VIEW_ACLS =
+ key("yarn.view.acls")
+ .stringType()
+ .defaultValue("")
+ .withDescription(
+ "Users and groups to give VIEW access. The ACLs
are of for"
+ + "
comma-separated-usersspacecomma-separated-groups");
+
+ /** Users and groups to give MODIFY access. */
+ public static final ConfigOption<String> APPLICATION_MODIFY_ACLS =
+ key("yarn.modify.acls")
+ .stringType()
+ .defaultValue("")
+ .withDescription(
+ "Users and groups to give MODIFY access. The ACLs
are of for"
Review Comment:
Ditto above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
