fredia commented on code in PR #22744:
URL: https://github.com/apache/flink/pull/22744#discussion_r1230401732
##########
flink-tests/src/test/java/org/apache/flink/test/state/ChangelogCompatibilityITCase.java:
##########
@@ -169,18 +160,32 @@ private String tryCheckpointAndStop(JobGraph jobGraph)
throws Exception {
}
}
- private void restoreAndValidate(String location) {
+ private void restoreAndValidate(String location) throws Exception {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.enableChangelogStateBackend(testCase.restoreWithChangelog);
JobGraph jobGraph = addGraph(env);
jobGraph.setSavepointRestoreSettings(forPath(location));
- if (tryRun(jobGraph) != testCase.allowRestore) {
Review Comment:
I think `tryRun(jobGraph) != testCase.allowRestore` contains two case of:
`restored && !testCase.allowRestore` and `!restored &&
testCase.allowRestore`.
why split it into two?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
