XComp commented on PR #22769: URL: https://github.com/apache/flink/pull/22769#issuecomment-1592466347
> I feel like the service should never call any driver method under the lock, but follow this pattern thinking I created FLINK-32339 to cover this issue and align the locking functionality: At least for the leadership confirmation we have definetly missed to move it into the leader operation executor. > I feel like the service should never call any driver method under the lock, but follow this pattern thinking I guess, your observation is correct: The remove call shouldn't call driver code direct but only trigger it (i.e. put it in the leader event queue). It does a cleanup of the entry only, anyway, which means that if it's actually processed, it either removes the entry when the leadership is still acquired or it is already overwritten when another process acquired leadership. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
