XComp commented on PR #22656:
URL: https://github.com/apache/flink/pull/22656#issuecomment-1593046291

   > Why wouldn't the service be able to forward errors to the contender? Is it 
because the driver is doing stuff internally that the service doesn't even know 
about?
   
   The k8s implementation forwards errors that were caught by the watcher to 
the contender independently of the calls the service sends to the driver.
   
   > How will the driver get access to a contender-specific failure handler?
   
   The driver got access to the error handler during instnatiation. I followed 
that approach for the `DefaultMultipleComponentLeaderElectionService`.
   
   > I'm wondering if rather there should be a way for the driver to report 
errors to the service, which forwards it to the contender.
   
   I could do that. Adding a `onError` method to the 
`MultipleComponentLeaderElectionService` through the `Listener` interface feels 
like the more consistent way of passing over the error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to