zentol commented on code in PR #22791:
URL: https://github.com/apache/flink/pull/22791#discussion_r1231158902
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcSystem.java:
##########
@@ -91,8 +93,11 @@ static RpcSystem load() {
* @return loaded RpcSystem
*/
static RpcSystem load(Configuration config) {
Review Comment:
~~We can of course set the main priority to 1 instead and reserve 0 for
testing or something~~
Missed that this is rpc-core territory.
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcSystem.java:
##########
@@ -91,8 +93,11 @@ static RpcSystem load() {
* @return loaded RpcSystem
*/
static RpcSystem load(Configuration config) {
Review Comment:
~~kinda? We could define a custom one that uses -1, but technically it
violates the contract (since 0 is MAX).~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
