masteryhx commented on code in PR #22772:
URL: https://github.com/apache/flink/pull/22772#discussion_r1231733767
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java:
##########
@@ -196,6 +204,23 @@ public void markTaskStart() {
this.taskStartTime = System.currentTimeMillis();
}
+ public void markTaskInitialize() {
+ this.taskInitializeTime = System.currentTimeMillis();
+ }
+
+ /**
+ * Return the duration of one task spends on restoring/initialization,
return 0 when the task is
+ * not in initialization.
+ */
+ @VisibleForTesting
+ public long getTaskInitializeTime() {
Review Comment:
I think this metric should be more similar to `TotalTime` or
`lastCheckpointRestoreTimestamp`: Return real value even if JobStatus has
changed/restored.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
