Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2690 This looks very good. To double check: Do we have tests for the following situations? - Records larger than buffers - Records such that they exactly line up with buffer size (full record and full buffer always coincide) If not, those would be important to have. Otherwise +1 to merge this to for both 1.2.0 and 1.1.4
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---