XComp commented on code in PR #22794:
URL: https://github.com/apache/flink/pull/22794#discussion_r1231921789
##########
flink-python/pyflink/pyflink_gateway_server.py:
##########
@@ -254,8 +254,10 @@ def launch_gateway_server_process(env, args):
[construct_flink_classpath(env), construct_hadoop_classpath(env)])
if "FLINK_TESTING" in env:
classpath = os.pathsep.join([classpath,
construct_test_classpath()])
- command = [java_executable, jvm_args,
"-XX:+IgnoreUnrecognizedVMOptions"] + jvm_opts \
- + log_settings + ["-cp", classpath, program_args.main_class] +
program_args.other_args
+ command = [java_executable, jvm_args,
"-XX:+IgnoreUnrecognizedVMOptions",
+ "--add-opens=jdk.proxy2/jdk.proxy2=ALL-UNNAMED"] \
Review Comment:
you said yes here but didn't follow-up with a comment ;-)
##########
flink-yarn/pom.xml:
##########
@@ -34,6 +34,10 @@ under the License.
<!-- for testing (will override Hadoop's default dependency on
too low SDK versions that
do not work with our httpcomponents version) -->
<aws.sdk.version>1.12.319</aws.sdk.version>
+ <surefire.module.config><!--
+ CommonTestUtils#setEnv
Review Comment:
odd formatting
##########
flink-table/flink-table-runtime/pom.xml:
##########
@@ -35,6 +35,15 @@ under the License.
<packaging>jar</packaging>
+ <properties>
+ <surefire.module.config><!--
+ chill ArraysAsListSerializer
Review Comment:
odd formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
