Matthias Pohl created FLINK-32368:
-------------------------------------
Summary: KubernetesTestFixture doesn't implement the
checkAndUpdateConfigMapFunction properly
Key: FLINK-32368
URL: https://issues.apache.org/jira/browse/FLINK-32368
Project: Flink
Issue Type: Bug
Components: Deployment / Kubernetes, Tests
Affects Versions: 1.17.1, 1.16.2, 1.18.0
Reporter: Matthias Pohl
[FlinkKubeClient.checkAndUpdateConfigMap|https://github.com/apache/flink/blob/ab3eb40d920fa609f49164a0bbb5fcbb3004a808/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/FlinkKubeClient.java#L163]
expects an error to be forwarded through the {{CompletableFuture}} instead of
throwing a {{RuntimeException}}.
The actual implementation implements it accordingly in
[Fabric8FlinkKubeClient:313|https://github.com/apache/flink/blob/025a95b627faf8ec8b725a7784d1279b41e10ba7/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L313]
where a {{CompletionException}} is thrown within the {{CompletableFuture}}'s
{{supplyAsync}} call resulting the future to fail.
{{KubernetesTestFixture}} doesn't make the returned future complete
exceptionally but throws a {{CompletionException}} (see
[KubernetesTestFixture:172|https://github.com/apache/flink/blob/6fc5f789869433688eb5f62494f1a4404e0dd11b/flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesTestFixture.java#L172]).
This results in inconsistent test behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
