XComp opened a new pull request, #22809: URL: https://github.com/apache/flink/pull/22809
## What is the purpose of the change [FlinkKubeClient.checkAndUpdateConfigMap](https://github.com/apache/flink/blob/ab3eb40d920fa609f49164a0bbb5fcbb3004a808/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/FlinkKubeClient.java#L163) expects an error to be forwarded through the `CompletableFuture` instead of throwing a `RuntimeException`. The actual implementation implements it accordingly in [Fabric8FlinkKubeClient:313](https://github.com/apache/flink/blob/025a95b627faf8ec8b725a7784d1279b41e10ba7/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L313) where a `CompletionException` is thrown within the `CompletableFuture`'s `supplyAsync` call resulting in the future to fail. `KubernetesTestFixture` doesn't make the returned future complete exceptionally but throws a `CompletionException` (see [KubernetesTestFixture:172](https://github.com/apache/flink/blob/6fc5f789869433688eb5f62494f1a4404e0dd11b/flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesTestFixture.java#L172)). This results in inconsistent test behavior. ## Brief change log * Updates the `KubernetesTestFixture` * adapts related tests ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
