gyfora commented on code in PR #621:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/621#discussion_r1232370679
##########
flink-kubernetes-operator/pom.xml:
##########
@@ -198,6 +198,13 @@ under the License.
<artifactId>junit-jupiter-params</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <version>${mockito.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Please avoid using Mockito as per the Flink coding guidelines:
https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-mockito---use-reusable-test-implementations
I suggest overriding the getPodList method of the standalone flink service
by hand or using the TestingFlinkService.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
