RyanSkraba commented on code in PR #22814:
URL: https://github.com/apache/flink/pull/22814#discussion_r1232566820


##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/ProtobufSQLITCaseTest.java:
##########
@@ -328,4 +331,33 @@ public void testSinkWithNullLiteralWithEscape() throws 
Exception {
         MapTest.InnerMessageTest innerMessageTest = 
mapTest.getMap2Map().get("b");
         assertEquals(MapTest.InnerMessageTest.getDefaultInstance(), 
innerMessageTest);
     }
+
+    @Test
+    public void testUnsupportedBulkFilesystemSink() {
+        env().setParallelism(1);
+        String sql =
+                "create table bigdata_sink ( "
+                        + "    a int, "
+                        + "    map1 map<string,string>,"
+                        + " map2 map<string, row<a int, b bigint>>"
+                        + ")  with ("
+                        + "    'connector' = 'filesystem', "
+                        + "    'path' = '/tmp/unused', "
+                        + "    'format' = 'protobuf', "
+                        + " 'protobuf.message-class-name' = 
'org.apache.flink.formats.protobuf.testproto.MapTest'"
+                        + ")";
+        tEnv().executeSql(sql);

Review Comment:
   I would have preferred to throw the exception here, but I didn't find the 
right hook into the connector.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to