LadyForest commented on code in PR #22539:
URL: https://github.com/apache/flink/pull/22539#discussion_r1230722665
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/ExecNodeGraphInternalPlan.java:
##########
@@ -75,6 +75,9 @@ public void writeToFile(File file, boolean ignoreIfExists,
boolean failIfExists)
}
}
try {
+ if (!file.getParentFile().exists()) {
Review Comment:
I don't think it's appropriate to make parent dirs here. The logic spreads
across multiple classes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
