[
https://issues.apache.org/jira/browse/FLINK-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609950#comment-15609950
]
ASF GitHub Bot commented on FLINK-4889:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2698
[FLINK-4889] [InstanceManager] Remove ActorRef dependency from
InstanceManager
The `InstanceManager` should not know about the underlying RPC abstraction,
namely Akka.
Therefore, the PR removes the dependency on ActorRef from the
`InstanceManager`. The mapping from `ActorRef` to `InstanceID` is now kept in
the `JobManager`.
This PR is a necessary refactoring for Flip-6.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink refactorInstanceManager
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2698
----
commit e8803d2c243d1dcbae5a7f1def88fed156ca9643
Author: Till Rohrmann <[email protected]>
Date: 2016-10-23T22:25:13Z
[FLINK-4889] [InstanceManager] Remove ActorRef dependency from
InstanceManager
The instance manager should not know about the underlying RPC abstraction,
namely Akka.
Therefore, the PR removes the dependency on ActorRef from the
InstanceManager.
----
> Make InstanceManager independent of ActorRef
> --------------------------------------------
>
> Key: FLINK-4889
> URL: https://issues.apache.org/jira/browse/FLINK-4889
> Project: Flink
> Issue Type: Improvement
> Components: JobManager
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> Currently, the {{InstanceManager}} strongly depends on {{ActorRef}}, because
> it uses the actor refs to distinguish task managers. I propose to make the
> {{InstanceManager}} independent of these {{ActorRefs}} because they are
> implementation dependent (see Flip-6).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
