ashangit commented on code in PR #622:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1235200832
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java:
##########
@@ -281,6 +284,17 @@ public static boolean
isUpgradeModeChangedToLastStateAndHADisabledPreviously(
&&
!HighAvailabilityMode.isHighAvailabilityModeActivated(observeConfig);
}
+ public static <SPEC extends AbstractFlinkSpec> SPEC getLastSpec(
+ AbstractFlinkResource<SPEC, ?> deployment) {
+ var reconciliationStatus =
deployment.getStatus().getReconciliationStatus();
+ var reconciliationState = reconciliationStatus.getState();
+ if (reconciliationState != ReconciliationState.ROLLED_BACK) {
+ return reconciliationStatus.deserializeLastReconciledSpec();
+ } else {
+ return reconciliationStatus.deserializeLastRollbackSpec();
Review Comment:
The lastReconcileSpec is updated now as we rely on same code path than the
upgrade one.
I will take a look to not update it but it looks quite strange to me to
finally not have the lastReconcile being aligned with the "current" running spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
