[ 
https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735346#comment-17735346
 ] 

Sergey Nuyanzin edited comment on FLINK-32379 at 6/20/23 5:17 PM:
------------------------------------------------------------------

-That I'm not sure....-
-Currently there is in use archunit which is junit5 based...-
-In this case instead of {{@Category}} there should be used {{@Tag}}.-
-At the same time rules are written in fields... while {{@Tag}} could be 
applied to type and methods only...--

UPD: it seems does the thing
this works locally

{code:java}
    @ArchTest
    @ArchTag(value = "org.apache.flink.testutils.junit.FailsOnJava11")
    @ArchTag(value = "org.apache.flink.testutils.junit.FailsOnJava17")
    public static final ArchRule CONNECTOR_CLASSES_ONLY_DEPEND_ON_PUBLIC_API =
...
{code}


was (Author: sergey nuyanzin):
That I'm not sure....
Currently there is in use archunit which is junit5 based...
In this case instead of {{@Category}} there should be used {{@Tag}}. 
At the same time rules are written in fields... while {{@Tag}} could be applied 
to type and methods only...

> Skip archunit tests in java1X-target profiles
> ---------------------------------------------
>
>                 Key: FLINK-32379
>                 URL: https://issues.apache.org/jira/browse/FLINK-32379
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Build System
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.18.0
>
>
> When compiling to Java 11/17 byte code archunit fails; not sure why. Maybe it 
> finds more/less stuff or signatures are represented differently.
> In any case let's use the Java 8 bytecode version as the "canonical" version 
> and skip archunit otherwise.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to