RocMarshal commented on code in PR #22847:
URL: https://github.com/apache/flink/pull/22847#discussion_r1240660246
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorAlignmentTest.java:
##########
@@ -46,12 +46,7 @@ Licensed to the Apache Software Foundation (ASF) under one
import java.util.concurrent.CompletableFuture;
import java.util.stream.Collectors;
-import static org.hamcrest.CoreMatchers.is;
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.contains;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/** Unit test for {@link SourceOperator} watermark alignment. */
Review Comment:
Good migration & supplementation~
Just a minor comment: what about removing the `public` (method or class
declaration) key-word to adapt the style of junit5 mentioned in the previous
discussion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
