KarmaGYZ commented on code in PR #22836:
URL: https://github.com/apache/flink/pull/22836#discussion_r1241830373
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java:
##########
@@ -18,33 +18,44 @@
package org.apache.flink.runtime.io.network.netty;
+import org.apache.flink.annotation.VisibleForTesting;
+
import org.apache.flink.shaded.netty4.io.netty.bootstrap.Bootstrap;
import org.apache.flink.shaded.netty4.io.netty.channel.ChannelException;
import org.apache.flink.shaded.netty4.io.netty.channel.ChannelFuture;
import org.apache.flink.shaded.netty4.io.netty.channel.ChannelInitializer;
import org.apache.flink.shaded.netty4.io.netty.channel.ChannelOption;
import org.apache.flink.shaded.netty4.io.netty.channel.epoll.Epoll;
+import
org.apache.flink.shaded.netty4.io.netty.channel.epoll.EpollChannelOption;
import
org.apache.flink.shaded.netty4.io.netty.channel.epoll.EpollEventLoopGroup;
import
org.apache.flink.shaded.netty4.io.netty.channel.epoll.EpollSocketChannel;
import org.apache.flink.shaded.netty4.io.netty.channel.nio.NioEventLoopGroup;
import org.apache.flink.shaded.netty4.io.netty.channel.socket.SocketChannel;
+import
org.apache.flink.shaded.netty4.io.netty.channel.socket.nio.NioChannelOption;
import
org.apache.flink.shaded.netty4.io.netty.channel.socket.nio.NioSocketChannel;
import org.apache.flink.shaded.netty4.io.netty.handler.ssl.SslHandler;
+import jdk.net.ExtendedSocketOptions;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import javax.annotation.Nullable;
import java.io.IOException;
+import java.lang.reflect.Field;
import java.net.InetSocketAddress;
+import java.net.SocketOption;
import static org.apache.flink.util.Preconditions.checkState;
class NettyClient {
private static final Logger LOG =
LoggerFactory.getLogger(NettyClient.class);
+ @VisibleForTesting static final String NIO_TCP_KEEPIDLE_KEY =
"TCP_KEEPIDLE";
+ @VisibleForTesting static final String NIO_TCP_KEEPINTERVAL_KEY =
"TCP_KEEPINTERVAL";
+ @VisibleForTesting static final String NIO_TCP_KEEPCOUNT_KEY =
"TCP_KEEPCOUNT";
Review Comment:
Could we leverage the `assumeThat` to only enable these tests in proper
environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
