masteryhx commented on code in PR #21835:
URL: https://github.com/apache/flink/pull/21835#discussion_r1241839333
##########
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java:
##########
@@ -433,6 +461,13 @@ public static class RocksdbCompactFilterCleanupStrategy
implements CleanupStrategies.CleanupStrategy {
private static final long serialVersionUID = 3109278796506988980L;
+ /**
+ * Default value lets RocksDB control this feature as needed. For now,
RocksDB will change
+ * this value to 30 days (i.e 30 * 24 * 60 * 60) so that every file
goes through the
+ * compaction process at least once every 30 days if not compacted
sooner.
+ */
+ static final Time DEFAULT_PERIODIC_COMPACTION_TIME =
Time.seconds(0xfffffffffffffffeL);
Review Comment:
I have used long type in the inner class to avoid the confusing semantics
and also update the doc.
Please take a review agiain, Thanks!
I will squash some commits when you approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
