lsyldliu commented on code in PR #22734: URL: https://github.com/apache/flink/pull/22734#discussion_r1242084504
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/fusion/OpFusionCodegenSpec.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.fusion; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.data.binary.BinaryRowData; +import org.apache.flink.table.planner.codegen.CodeGeneratorContext; +import org.apache.flink.table.planner.codegen.ExprCodeGenerator; +import org.apache.flink.table.planner.codegen.GeneratedExpression; + +import java.util.List; +import java.util.Set; + +/** An interface for those physical operators that support operator fusion codegen. */ +@Internal +public interface OpFusionCodegenSpec { + + /** + * Initializes the operator spec. Sets access to the context. This method must be called before + * doProduce and doConsume related methods. + */ + void setup(OpFusionContext opFusionContext); + + /** Prefix used in the current operator's variable names. */ + String variablePrefix(); Review Comment: Intuitively, it's fine to use class names. But I feel like using class names would result in long variable names, and it makes sense to provide this interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
