gyfora commented on code in PR #622:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1242178150


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java:
##########
@@ -140,6 +141,12 @@ public UpdateControl<FlinkDeployment> 
reconcile(FlinkDeployment flinkApp, Contex
                         previousDeployment,
                         false);
             }
+            // Rely on the last stable spec if rolling back
+            if (flinkApp.getStatus().getReconciliationStatus().getState()
+                    == ReconciliationState.ROLLING_BACK) {
+                flinkApp.setSpec(
+                        
flinkApp.getStatus().getReconciliationStatus().deserializeLastStableSpec());

Review Comment:
   so I believe we should not need any additional logic to change what was 
returned 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to