XComp commented on code in PR #22661:
URL: https://github.com/apache/flink/pull/22661#discussion_r1242213306
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java:
##########
@@ -666,66 +667,38 @@ void testErrorIsIgnoredAfterLeaderElectionBeingClosed()
throws Exception {
leaderElection.close();
-
testingLeaderElectionDriver.onFatalError(testException);
+
testingLeaderElectionDriver.triggerErrorHandling(testException);
assertThat(testingContender.getError()).isNull();
});
}
};
}
- /**
- * Tests that we can shut down the DefaultLeaderElectionService if the
used LeaderElectionDriver
- * holds an internal lock. See FLINK-20008 for more details.
- */
- @Test
- void testServiceShutDownWithSynchronizedDriver() throws Exception {
Review Comment:
Yes, see the corresponding commit message:
```
[test] Removes testServiceShutDownWithSynchronizedDriver
It should essentially test the same thing as testCloseGrantDeadlock
according to the description of FLINK-20008
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
