lindong28 commented on code in PR #22670:
URL: https://github.com/apache/flink/pull/22670#discussion_r1243250725
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java:
##########
@@ -236,6 +239,16 @@ public SchedulerBase(
this.exceptionHistory =
new BoundedFIFOQueue<>(
jobMasterConfiguration.getInteger(WebOptions.MAX_EXCEPTION_HISTORY_SIZE));
+
+ this.finishingTasks = createFinishingTasks();
+ }
+
+ private Map<JobVertexID, BitSet> createFinishingTasks() {
+ Map<JobVertexID, BitSet> map = new HashMap<>();
+ for (ExecutionJobVertex vertex :
getExecutionGraph().getAllVertices().values()) {
+ map.put(vertex.getJobVertexId(), new BitSet());
Review Comment:
Should we exclude ExecutionVertex that has been marked finished?
Otherwise, suppose the job is restarted after some tasks finished. Then
checkpoint will not be triggered even if all tasks have finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
