pnowojski commented on code in PR #75:
URL: https://github.com/apache/flink-benchmarks/pull/75#discussion_r1244067875
##########
src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java:
##########
@@ -57,7 +56,7 @@ public class StateBenchmarkBase extends BenchmarkBase {
static AtomicInteger keyIndex;
final ThreadLocalRandom random = ThreadLocalRandom.current();
- @Param({"HEAP", "ROCKSDB"})
+ @Param({"HEAP", "ROCKSDB", "HEAP_CHANGELOG", "ROCKSDB_CHANGELOG"})
Review Comment:
I would remove `HEAP_CHANGELOG` from the runs. This sounds like a quite
unlikely production combination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
