swuferhong commented on code in PR #22856:
URL: https://github.com/apache/flink/pull/22856#discussion_r1244561682
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/agg/HashAggITCase.scala:
##########
@@ -21,21 +21,33 @@ import org.apache.flink.api.scala._
import org.apache.flink.table.api.DataTypes
import org.apache.flink.table.api.config.{ExecutionConfigOptions,
OptimizerConfigOptions}
import org.apache.flink.table.planner.codegen.agg.batch.HashAggCodeGenerator
+import org.apache.flink.table.planner.plan.stats.FlinkStatistic
import org.apache.flink.table.planner.runtime.utils.BatchTestBase.row
+import org.apache.flink.table.planner.runtime.utils.TestData.{data2,
nullablesOfData2, type2}
import org.apache.flink.testutils.junit.extensions.parameterized.{Parameter,
ParameterizedTestExtension, Parameters}
import org.junit.jupiter.api.TestTemplate
import org.junit.jupiter.api.extension.ExtendWith
import java.math.BigDecimal
+import scala.collection.JavaConverters._
+
/** AggregateITCase using HashAgg Operator. */
@ExtendWith(Array(classOf[ParameterizedTestExtension]))
class HashAggITCase extends AggregateITCaseBase("HashAggregate") {
@Parameter var adaptiveLocalHashAggEnable: Boolean = _
override def prepareAggOp(): Unit = {
+ registerCollection(
+ "AuxGroupingTable",
+ data2,
+ type2,
+ "a, b, c, d, e",
+ nullablesOfData2,
Review Comment:
As setting column `a` as the unique key, but column `a` in dataset `data2`
doesn't meet the requirement of unique key. plz reconstruct the test dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
