zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246032593
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java:
##########
@@ -390,23 +393,36 @@ public void release() {
}
protected static final PreviousSnapshot EMPTY_PREVIOUS_SNAPSHOT =
- new PreviousSnapshot(Collections.emptyMap());
+ new PreviousSnapshot(Collections.emptyList());
/** Previous snapshot with uploaded sst files. */
protected static class PreviousSnapshot {
- @Nullable private final Map<StateHandleID, Long> confirmedSstFiles;
-
- protected PreviousSnapshot(@Nullable Map<StateHandleID, Long>
confirmedSstFiles) {
- this.confirmedSstFiles = confirmedSstFiles;
+ @Nonnull private final Map<String, StreamStateHandle>
confirmedSstFiles;
+
+ protected PreviousSnapshot(@Nullable Collection<HandleAndLocalPath>
confirmedSstFiles) {
+ this.confirmedSstFiles =
+ confirmedSstFiles != null
+ ? confirmedSstFiles.stream()
+ .collect(
+ Collectors.toMap(
+
HandleAndLocalPath::getLocalPath,
+
HandleAndLocalPath::getHandle))
+ : Collections.emptyMap();
}
- protected Optional<StreamStateHandle> getUploaded(StateHandleID
stateHandleID) {
- if (confirmedSstFiles != null &&
confirmedSstFiles.containsKey(stateHandleID)) {
- // we introduce a placeholder state handle, that is replaced
with the
- // original from the shared state registry (created from a
previous checkpoint)
- return Optional.of(
- new
PlaceholderStreamStateHandle(confirmedSstFiles.get(stateHandleID)));
+ protected Optional<StreamStateHandle> getUploaded(String filename) {
+ if (confirmedSstFiles.containsKey(filename)) {
+ StreamStateHandle handle = confirmedSstFiles.get(filename);
+ if (handle instanceof ByteStreamStateHandle) {
Review Comment:
I see, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
