wanglijie95 commented on code in PR #22674:
URL: https://github.com/apache/flink/pull/22674#discussion_r1246130385


##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -717,6 +717,18 @@ public boolean isOnlyConsumeFinishedPartition() {
                                                             
code(UNFINISHED_PRODUCERS.name())))
                                             .build());
 
+    @Documentation.ExcludeFromDocumentation(
+            "this is an expert option, that we do not want to expose in the 
documentation")
+    public static final ConfigOption<Integer> 
OFFLOAD_SHUFFLE_DESCRIPTORS_THRESHOLD =

Review Comment:
   I suggest to move this config option to `TaskDeploymentDescriptorFactory` 
and marked as `@Experimental`. We can put it back to `JobManagerOptions`  when 
we think it should be exposed to users



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to