jiangxin369 commented on code in PR #245:
URL: https://github.com/apache/flink-ml/pull/245#discussion_r1246266124
##########
docs/content/docs/try-flink-ml/python/quick-start.md:
##########
@@ -271,27 +271,20 @@ initialization.
{{< stable >}}
-Please [download the correponding binary
-release](https://flink.apache.org/downloads.html) of Flink ML, then extract the
-archive:
+Please download [Flink ML Python
+source](https://flink.apache.org/downloads.html) and extract the jar files into
+Flink's library folder.
```shell
-tar -xzf flink-ml-*.tgz
-```
-
-Then you may copy the extracted library files to Flink's folder with the
-following commands.
-
-```shell
-cd ${path_to_flink_ml}
-cp ./lib/*.jar $FLINK_HOME/lib/
+tar -xzf apache-flink-ml*.tar.gz
+cp apache-flink-ml-*/deps/lib/* $FLINK_HOME/lib/
```
{{< /stable >}} {{< unstable >}}
Given that you have followed this [guideline]({{< ref
"docs/development/build-and-install#build-and-install-python-sdk" >}}), you
-would have already built Flink ML's Java SDK. Now, you need to copy the
+would have already built Flink ML's Python SDK. Now, you need to copy the
Review Comment:
I suppose here should be Java SDK, and the ref should be
"docs/development/build-and-install#build-and-install-java-sdk". Because the
following sentence says "copy the generated library files" which should be java
libraries.
##########
docs/content/docs/try-flink-ml/java/quick-start.md:
##########
@@ -73,20 +72,13 @@ initialization.
{{< stable >}}
-Please [download the correponding binary
-release](https://flink.apache.org/downloads.html) of Flink ML, then extract the
-archive:
+Please download [Flink ML Python
+source](https://flink.apache.org/downloads.html) and extract the jar files into
Review Comment:
I didn't find the apache-flink-ml*.tar.gz on this website, only source file
[flink-ml-2.2.0-src.tgz](https://dlcdn.apache.org/flink/flink-ml-2.2.0/flink-ml-2.2.0-src.tgz)
is available, which doesn't contains ".../deps/lib/*.jar"
##########
docs/content/docs/try-flink-ml/python/quick-start.md:
##########
@@ -271,27 +271,20 @@ initialization.
{{< stable >}}
-Please [download the correponding binary
-release](https://flink.apache.org/downloads.html) of Flink ML, then extract the
-archive:
+Please download [Flink ML Python
+source](https://flink.apache.org/downloads.html) and extract the jar files into
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
