liuyongvs commented on code in PR #22917:
URL: https://github.com/apache/flink/pull/22917#discussion_r1247686541
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java:
##########
@@ -632,7 +632,8 @@ private Stream<TestSetSpec> arrayMaxTestCases() {
LocalDate.of(2012, 5, 16),
LocalDate.of(2092, 7, 19)
},
- null)
+ null,
+ new Integer[] {1, 2})
.andDataTypes(
DataTypes.ARRAY(DataTypes.INT()),
Review Comment:
comments:
why not add unit test
new Integer[]{}, because the flink's array constuctor function is different
from spark
flink should contain at least 1 args.
spark can contain zero arg, for example array()
but they both can be empty array, for example, udf, user can constuct empty
array by themself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
