afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1247721510
########## flink-connectors/flink-connector-datagen-test/pom.xml: ########## @@ -0,0 +1,89 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-connectors</artifactId> + <version>1.18-SNAPSHOT</version> + </parent> + + <artifactId>flink-connector-datagen-tests</artifactId> Review Comment: I believe the only options we have are: 1. Drop the DataGen ITCase - not good 2. Move the DataGen ITCase into `flink-streaming-java` - weird 3. Continue with the `flink-connector-datagen-tests` split - not great, not terrible (c) 4. Move `#fromCollection()` methods into `flink-datagen` - not great because it breaks the familiar pattern, but since a lot of things will probably change in 2.0 anyway, this should be fine. An open question is whether we want to also add a dependency from `flink-datagen` to `flink-streaming-java`. This will improve usability, otherwise the end result will look somewhat like this: ``` Collection<Integer> data = ...; DataGenSource<Integer> collectionSource = DataGenSource.fromCollection(data); DataStreamSource<Integer> source = env.fromSource(collectionSource, WatermarkStrategy.forMonotonousTimestamps(), "Collection source") .forceNonParallel(); ``` Especially the necessity for the `forceNonParallel()/setParallelism(1)` call is concerning because it is easy to forget. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
