[
https://issues.apache.org/jira/browse/FLINK-32495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739026#comment-17739026
]
Rui Fan commented on FLINK-32495:
---------------------------------
Merged
<master:1.18> 24e479571facd07ff129c57cda86c7e34d4637bd to
9d7b1663296ef6f85572314a2b26a716981d8bff
1.17 b4e02ab2a27ed8621f0fa0c759b2f58f14d770d4
1.16 403c74d1de01c075aafe824e8f7f8428e477992f
> SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails
> ------------------------------------------------------------------------
>
> Key: FLINK-32495
> URL: https://issues.apache.org/jira/browse/FLINK-32495
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Common
> Reporter: Rui Fan
> Assignee: Rui Fan
> Priority: Blocker
> Labels: pull-request-available
> Attachments: image-2023-06-30-10-53-50-280.png,
> image-2023-06-30-13-01-26-519.png, image-2023-06-30-13-02-32-803.png
>
>
> SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails.
> I analyzed this CI :
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=50668&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=9089]
> h1. Root cause:
> * The CoordinatorExecutorThreadFactory cannot new multiple threads. And too
> many callers will check
> `coordinatorThreadFactory.isCurrentThreadCoordinatorThread()`, such as:
> SourceCoordinatorContext.attemptReady.
> * The CoordinatorExecutorThreadFactory is shared at
> [SourceCoordinatorTestBase|https://github.com/apache/flink/blob/21eba4ca4cb235a2189c94cdbf3abcec5cde1e6e/flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorTestBase.java#L68]
> * It will be used at multiple source coordinator, and the second source
> coordinator will overwrite the CoordinatorExecutorThreadFactory#t, so the
> check will fail for the first source.
> h1. Solution:
> Don't share the CoordinatorExecutorThreadFactory.
> h1. log:
> !image-2023-06-30-10-53-50-280.png!
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
