zentol commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1247825780
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,12 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}",
throwable.getMessage());
- } else {
- log.error("Unhandled exception.", throwable);
- }
+ log.error("Unhandled exception.", throwable);
Review Comment:
This should still be reverted
##########
flink-end-to-end-tests/run-nightly-tests.sh:
##########
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective shuffle"
"$END_TO_END_DIR/test-scripts/test_batch_sql.sh hybrid_selective"
run_test "Streaming SQL end-to-end test using planner loader"
"$END_TO_END_DIR/test-scripts/test_streaming_sql.sh" "skip_check_exceptions"
run_test "Streaming SQL end-to-end test using planner with Scala version"
"$END_TO_END_DIR/test-scripts/test_streaming_sql.sh scala-planner"
"skip_check_exceptions"
- run_test "Sql Jdbc Driver end-to-end test"
"$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh"
+ run_test "Sql Jdbc Driver end-to-end test"
"$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh skip_check_exceptions"
Review Comment:
This will skip all exception checks. Are you _sure_ you want that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
