jeremy-degroot commented on code in PR #20:
URL:
https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1247861906
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java:
##########
@@ -98,20 +98,24 @@
private final KafkaRecordDeserializationSchema<OUT> deserializationSchema;
// The configurations.
private final Properties props;
+ // Client rackId callback
+ private final Supplier<String> rackIdSupplier;
Review Comment:
You're right about the Serializable bit, good catch.
Is there a straightforward way to do that while still allowing for Lambdas?
Maybe provide one method for the basic Supplier and another for
ClosableSerializableSupplier for when you need that degree of safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
