XComp opened a new pull request, #22919:
URL: https://github.com/apache/flink/pull/22919
## What is the purpose of the change
The driver doesn't need to be instantiated when the
`DefaultLeaderElectionService` is instantiated. Instead, we can instantiated
when the first contender is registered. This way we can avoid creating the
`DefaultLeaderElectionService` lazily in the HaServices.
## Brief change log
* Made `startLeaderElectionBackend` private
* Calls the method instead in `DefaultLeaderElectionService#register`
* Aligned Preconditions in `DefaultLeaderElectionService` accordingly
## Verifying this change
* Adds testcase for verifying the lazy driver instantiation
* Adds tests for proper close handling
* Removes
`DefaultLeaderElectionServiceTest#testContenderRegistrationWithoutDriverBeingInstantiatedFails`
because this case isn't possible anymore: The driver instantiation always
happens when registering the first contender
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
