hanyuzheng7 commented on code in PR #22917:
URL: https://github.com/apache/flink/pull/22917#discussion_r1248317688


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -303,7 +302,7 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
                     .name("ARRAY_MAX")
                     .kind(SCALAR)
                     .inputTypeStrategy(arrayFullyComparableElementType())
-                    .outputTypeStrategy(new ArrayElementOutputTypeStrategy())
+                    
.outputTypeStrategy(forceNullable(SpecificTypeStrategies.ARRAY_ELEMENT))

Review Comment:
   Hi, @liuyongvs I also have question about this, you use forceNullable to 
force INT NOT NULL -> INT.
   But the SpecificTypeStrategies.ARRAY_ELEMENT return type is INT NOT NULL, 
does it?
   
   why don't use force INT NOT NULL -> INT here
   https://github.com/apache/flink/pull/22917#discussion_r1248318340



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to