chucheng92 opened a new pull request, #38: URL: https://github.com/apache/flink-connector-kafka/pull/38
## What is the purpose of the change Currently, externalized sql connector rely on flink main repo. but flink main repo has many test cases(especially in flink python) reference flink sql kafka connector. If we change the dependencies(e.g. commons-collections) in flink main repo, it will cause exception. We should let externalized flink connectors depend on flink main, not the other way around. So we need to add this dependency in shade jar. Otherwise, it will cause external components block the upgrade of flink main. ## Brief change log update pom ## Verifying this change This change is a trivial rework / code cleanup. Verifying by current total cases. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): yes - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
