zentol commented on code in PR #22893:
URL: https://github.com/apache/flink/pull/22893#discussion_r1251051570
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java:
##########
@@ -247,38 +247,33 @@ void
testDelayedGrantCallAfterContenderBeingDeregisteredAgain() throws Exception
};
}
- /**
- * Test to cover the issue described in FLINK-31814. This test could be
removed after
- * FLINK-31814 is resolved.
- */
@Test
- void testOnRevokeCallWhileClosingService() throws Exception {
- final TestingLeaderElectionDriver.TestingLeaderElectionDriverFactory
driverFactory =
- new
TestingLeaderElectionDriver.TestingLeaderElectionDriverFactory(
- LeaderElectionEventHandler::onRevokeLeadership);
-
- try (final DefaultLeaderElectionService testInstance =
- new DefaultLeaderElectionService(
- driverFactory,
fatalErrorHandlerExtension.getTestingFatalErrorHandler())) {
- testInstance.startLeaderElectionBackend();
-
- final TestingLeaderElectionDriver driver =
driverFactory.getCurrentLeaderDriver();
- assertThat(driver).isNotNull();
-
- driver.isLeader();
-
- final LeaderElection leaderElection =
-
testInstance.createLeaderElection(createRandomContenderID());
- final TestingContender contender =
- new TestingContender("unused-address", leaderElection);
- contender.startLeaderElection();
+ void testDelayedRevokeCallAfterContenderBeingDeregisteredAgain() throws
Exception {
Review Comment:
it would be good to clarify where the interesting assertions (that something
doesnt throw an exception) occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
