hanyuzheng7 commented on code in PR #22834:
URL: https://github.com/apache/flink/pull/22834#discussion_r1251073934
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -275,6 +275,20 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
"org.apache.flink.table.runtime.functions.scalar.ArrayReverseFunction")
.build();
+ public static final BuiltInFunctionDefinition ARRAY_SLICE =
+ BuiltInFunctionDefinition.newBuilder()
+ .name("ARRAY_SLICE")
+ .kind(SCALAR)
+ .inputTypeStrategy(
+ sequence(
+ logical(LogicalTypeRoot.ARRAY),
+ logical(LogicalTypeRoot.INTEGER),
+ logical(LogicalTypeRoot.INTEGER)))
+ .outputTypeStrategy(nullableIfArgs(argument(0)))
Review Comment:
> can we have it optional as it was suggested in the mentioned jira's issue
or is there any blocker for that?
No blocker, just need to change the BuiltinDefinination.
But what I worry about is that the current description of this function is
already very complicated. If the third args becomes optional again, is it too
complicated for users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
