snuyanzin commented on code in PR #22834:
URL: https://github.com/apache/flink/pull/22834#discussion_r1251156118
##########
docs/data/sql_functions.yml:
##########
@@ -643,6 +643,9 @@ collection:
- sql: ARRAY_REVERSE(haystack)
table: haystack.arrayReverse()
description: Returns an array in reverse order. If the array itself is
null, the function will return null.
+ - sql: ARRAY_SLICE(array, start_offset, end_offset)
+ table: array.arraySlice(start_offset, end_offset)
+ description: Returns a subarray of the input array between 'start_offset'
and ending at 'end_offset' inclusive. The offsets are 1-based however 0 is also
treated as the beginning of the array. Positive values are counted from the
beginning of the array while negative from the end. If 'start_offset' is after
'end_offset' an empty array will be returned. If both 'start_offset' and
'end_offset' are out of array bounds an empty array will be returned. Returns
null if any input is null.
Review Comment:
```suggestion
description: Returns a subarray of the input array between
'start_offset' and 'end_offset' inclusive. The offsets are 1-based however 0 is
also treated as the beginning of the array. Positive values are counted from
the beginning of the array while negative from the end. If 'start_offset' is
after 'end_offset' or both 'start_offset' and 'end_offset' are out of array
bounds an empty array will be returned. Returns null if any input is null.
```
`ending a` could be removed, also a couple of sentencies could be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
