XComp commented on code in PR #22844:
URL: https://github.com/apache/flink/pull/22844#discussion_r1251577433
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java:
##########
@@ -932,38 +1064,71 @@ void runTestWithManuallyTriggeredEvents(
void runTest(RunnableWithException testMethod, ExecutorService
leaderEventOperationExecutor)
throws Exception {
- try {
- leaderElectionService =
- new DefaultLeaderElectionService(
- driverFactory,
-
DefaultLeaderElectionServiceTest.this.fatalErrorHandlerExtension
- .getTestingFatalErrorHandler(),
- leaderEventOperationExecutor);
+ try (final DefaultLeaderElectionService localLeaderElectionService
=
+ new DefaultLeaderElectionService(
+ driverFactory,
+
DefaultLeaderElectionServiceTest.this.fatalErrorHandlerExtension
+ .getTestingFatalErrorHandler(),
+ leaderEventOperationExecutor)) {
+ leaderElectionService = localLeaderElectionService;
leaderElectionService.startLeaderElectionBackend();
testingLeaderElectionDriver =
driverFactory.assertAndGetOnlyCreatedDriver();
- leaderElection =
leaderElectionService.createLeaderElection(contenderID);
- testingContender = new TestingContender(TEST_URL,
leaderElection);
- testingContender.startLeaderElection();
+ try (final ContenderContext localContenderContext0 =
+ ContenderContext.create(0,
leaderElectionService);
+ final ContenderContext localContenderContext1 =
+ ContenderContext.create(1,
leaderElectionService)) {
+ this.contenderContext0 = localContenderContext0;
+ this.contenderContext1 = localContenderContext1;
Review Comment:
Yes, the purpose was to have the `DefaultLeaderElectionServiceTest`
providing functionality for multiple contenders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
