[
https://issues.apache.org/jira/browse/FLINK-32353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740251#comment-17740251
]
Etienne Chauchot edited comment on FLINK-32353 at 7/5/23 3:05 PM:
------------------------------------------------------------------
The mini cluster rule has been fixed in [Flink
1.18|https://github.com/apache/flink/pull/22399/]
* CassandraConnectorITCase does not use/needs MiniCluster so it is still an
"violation" but the rule message has changed.
* the "violation" for CassandraSourceITCase is now gone as the rule was fixed
To get rid of this failure when testing against flink 1.18, we need to update
the archunit violation store. But as part of [this
email|https://lists.apache.org/thread/pr0g812olzpgz21d9oodhc46db9jpxo3] , I'll
update the violation store only when flink 1.18 is the main supported version
for the Cassandra connector, surely short after this flink release is out.
was (Author: echauchot):
Regarding [this
email|https://lists.apache.org/thread/pr0g812olzpgz21d9oodhc46db9jpxo3] , I'll
add the "normal" archunit violations that comply to 1.18 when this version is
main supported version for the Cassandra connector.
> Make Cassandra connector tests compatible with archunit rules
> -------------------------------------------------------------
>
> Key: FLINK-32353
> URL: https://issues.apache.org/jira/browse/FLINK-32353
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Cassandra
> Reporter: Martijn Visser
> Assignee: Etienne Chauchot
> Priority: Major
> Labels: pull-request-available
>
> The current Cassandra connector in {{main}} fails when testing against Flink
> 1.18-SNAPSHOT
> {code:java}
> Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.1 s
> <<< FAILURE! - in org.apache.flink.architecture.rules.ITCaseRules
> Error: ITCaseRules.ITCASE_USE_MINICLUSTER Time elapsed: 0.025 s <<<
> FAILURE!
> java.lang.AssertionError:
> Architecture Violation [Priority: MEDIUM] - Rule 'ITCASE tests should use a
> MiniCluster resource or extension' was violated (1 times):
> org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase does
> not satisfy: only one of the following predicates match:
> * reside in a package 'org.apache.flink.runtime.*' and contain any fields
> that are static, final, and of type InternalMiniClusterExtension and
> annotated with @RegisterExtension
> * reside outside of package 'org.apache.flink.runtime.*' and contain any
> fields that are static, final, and of type MiniClusterExtension and annotated
> with @RegisterExtension or are , and of type MiniClusterTestEnvironment and
> annotated with @TestEnv
> * reside in a package 'org.apache.flink.runtime.*' and is annotated with
> @ExtendWith with class InternalMiniClusterExtension
> * reside outside of package 'org.apache.flink.runtime.*' and is annotated
> with @ExtendWith with class MiniClusterExtension
> or contain any fields that are public, static, and of type
> MiniClusterWithClientResource and final and annotated with @ClassRule or
> contain any fields that is of type MiniClusterWithClientResource and public
> and final and not static and annotated with @Rule
> {code}
> https://github.com/apache/flink-connector-cassandra/actions/runs/5276835802/jobs/9544092571#step:13:811
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
