tweise commented on code in PR #22810:
URL: https://github.com/apache/flink/pull/22810#discussion_r1253612690
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestClientTest.java:
##########
@@ -84,6 +89,26 @@ public void testConnectionTimeout() throws Exception {
}
}
+ @Test
+ public void testHttpsConnectionWithDefaultCerts() throws Exception {
+ final Configuration config = new Configuration();
+ final URL httpsUrl = new URL("https://raw.githubusercontent.com";);
Review Comment:
Dependency on that endpoint is not ideal for a unit test. However, given
that the CI setup already won't function w/o that connection and the difficulty
to test this specific functionality (HTTPS with default keystore), I think this
exception is justifiable. I would suggest though to add a comment though for
the unlikely case that someone runs tests locally and is not connected to the
internet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
