swuferhong commented on code in PR #22918:
URL: https://github.com/apache/flink/pull/22918#discussion_r1253827159


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdSelectivity.scala:
##########
@@ -256,6 +257,13 @@ class FlinkRelMdSelectivity private extends 
MetadataHandler[BuiltInMetadata.Sele
     }
   }
 
+  def getSelectivity(
+      rel: CommonPhysicalWindowTableFunction,
+      mq: RelMetadataQuery,
+      predicate: RexNode): JDouble = {
+    estimateSelectivity(rel, mq, predicate)
+  }
+

Review Comment:
   Although this method `getSelectivity(rel: RelNode, mq: RelMetadataQuery, 
predicate: RexNode)` is only effective for `BatchPhysicalRel`, I think most of 
the methods are actually effective for stream operators. Can we remove this 
limitation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to