fredia commented on code in PR #22890:
URL: https://github.com/apache/flink/pull/22890#discussion_r1254083925
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -510,6 +517,38 @@ protected StreamTask(
}
}
+ private CheckpointStorageAccess applyFileMergingCheckpoint(
+ CheckpointStorageAccess checkpointStorageAccess,
+ FileMergingSnapshotManager fileMergingSnapshotManager) {
+ if (fileMergingSnapshotManager == null
+ || fileMergingSnapshotManager instanceof
NonFileMergingSnapshotManager) {
+ return checkpointStorageAccess;
+ }
+
+ if (!(checkpointStorageAccess instanceof FsCheckpointStorageAccess)) {
+ LOG.warn(
+ "Unsupported checkpoint storage access for file merging:
{}. "
+ + "Falling back to original checkpoint storage
access.",
+ checkpointStorageAccess.getClass());
+ return checkpointStorageAccess;
+ }
+
+ try {
+ FsMergingCheckpointStorageAccess mergingCheckpointStorageAccess =
+ ((FsCheckpointStorageAccess) checkpointStorageAccess)
+
.toMergingStorageAccess(fileMergingSnapshotManager, environment);
Review Comment:
I moved `toMergingStorageAccess ` to `CheckpointStorageWorkerView`(Methods
of this interface act as a worker role in task manager), and removed the logic
of type checking in StreamTask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
